Fix dataset tests #562
Open
Fix dataset tests #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13530332879Details
💛 - Coveralls |
|
It fails on python versions 3.11, 3.12, with errors in creating temp directories. Not sure about the reason. |
rettigl
reviewed
Feb 28, 2025
| json_path_user = USER_CONFIG_PATH.joinpath("datasets.json") | ||
| def test_get_remove_dataset(requests_mock, zip_buffer, tmp_path): | ||
| """Test to get a dataset, verify its directory and files, and then remove the dataset.""" | ||
| json_path_user = tmp_path / USER_CONFIG_PATH / "datasets.json" |
There was a problem hiding this comment.
This doesn't use a temp path, but the user config. Not sure why. I think you should patch the USER_CONFIG_PATH instead.
|
There are strong interconnections and race conditions between the different tests, as they all access the same datasets.json files as defined by the static dm. This needs also to be resolved, parallel running test very often fail randomly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559 and also moves the dataset documentation to an easily accessible place for users (also changed to md file for ease of updating).
Currently available here: https://opencompes.github.io/docs/sed/develop/user_guide/dataset.html (might change when another build is done)